FE-1509: Surface cycles and initial places across the notebook - #9432
Draft
kube wants to merge 1 commit into
Draft
FE-1509: Surface cycles and initial places across the notebook#9432kube wants to merge 1 commit into
kube wants to merge 1 commit into
Conversation
Cell rows gain a tinted ↻ badge for cycle members and a blue initial badge for places the net cannot seed itself; hovering a badge lights the whole cycle up in the list and the graph. Topological ordering hoists the seed places to the front of the flow. In the graph explorer, cycle members carry dashed rings (solid while their cycle is hovered, with intra-cycle edges recoloured to match), initial places a hollow token marker inside the node, and the header counts both.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
area/libs
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Surfaces the structural analyses from #9431 across the notebook: cycle and initial-place badges in the cell list, rings and markers in the graph explorer, and hover-highlighting that ties the two together.
🔗 Related links
🔍 What does this change?
↻Nbadge for cycle members and a blueinitialbadge for places the net cannot seed itself; hovering a badge lights the whole cycle up in both the list and the graph.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
The algorithms are covered in #9431; the badge/ring rendering and hover propagation are exercised manually per the steps below.
❓ How to test this?
initialbadges; Infected and Infection carry↻1badges. Hover a badge — the cycle lights up in the list and the graph.📹 Demo
Screenshot pending — to be added before review.