FE-1500: add controlled Petrinaut navigation - #9426
Draft
kube wants to merge 2 commits into
Draft
Conversation
github-actions
Bot
added
area/infra
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Makes Petrinaut's app location controllable by the host: a new
navigationprop accepts a router-neutral controller through which mode, Simulate section and resource, scenario, subnet, canvas selection, and creation drawers can be read, driven, and recorded as browser history. Without the prop, behaviour is unchanged. Stacked on the presentation-profiles PR.🔗 Related links
🔍 What does this change?
react/navigationmodule:PetrinautNavigationState, a controller contract (state+onNavigatewith updater functions), navigation intents with a push-vs-replace history policy, selection canonicalization, and helpers such asopenPetrinautSimulationResourceandrevealPetrinautEditorItem.EditorProviderderives mode, Simulate view, drawer, and selection from navigation state; experiments, optimizations, simulation-scenario, and subnet selection navigate instead of setting local state; invalid locations normalize back with replace-history intents.SimulationCreationDrawerhost replaces the per-view drawer mounts, so opening and closing scenario, metric, experiment, and optimization drawers participates in Back/Forward.drawing-a-net.md,experiments.md,visual-settings.md).Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
react/navigation/index.test.tsx(controlled and uncontrolled providers, intents, canonicalization, drawer conversions),react/simulation/provider.test.tsx(scenario selection canonicalization),simulation-creation-drawer.test.tsx, and navigation assertions in the experiments and optimizations provider tests.❓ How to test this?
yarn workspace @hashintel/petrinaut dev.