FE-1533: Add a petrinaut-shipping skill to the repo skills - #9392
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
2f7a2aa to
830022a
Compare
PR SummaryLow Risk Overview Wires it into the existing skills layout with Reviewed by Cursor Bugbot for commit 9990f1a. Bugbot is set up for automated code reviews on this repo. Configure here. |
830022a to
b60b8d3
Compare
lunelson
left a comment
There was a problem hiding this comment.
Cool. The one thing that's odd here to me, although I know it's a pre-existing convention in this repo, is this non-standard frontmatter on the SKILL.md:
metadata:
triggers:
type: domain
enforcement: suggest
...The Agent Skills spec defines metadata as a string-to-string map, so a nested triggers object is non-conforming. A few concerns:
- It creates two routing systems: the
description-based model routing and HASH’s keyword/regex hook. - Several fields are still decorative anyway: the Claude hook reads prompt triggers and priority, but not
fileTriggers,enforcement,blockMessage, orskipConditions. - The broad keywords are already causing trouble: Cursor correctly noted that
changesetfuzzy-matches unrelated prompts. - Putting Claude-specific machinery in canonical
.agents/skillssomewhat undermines the supposed cross-agent portability. - The generated JSON makes the same configuration appear in three places: description, trigger metadata, and generated rules.
Personally I would remove metadata.triggers and rely on a precise description. If Claude-only activation is genuinely required, we should maybe work out a way to keep that configuration in a Claude-specific sidecar; or else find a way to encode it as a namespaced string-valued metadata field so the skill remains spec-compliant.
b60b8d3 to
5ec3425
Compare
5ec3425 to
d167777
Compare
|
Sadly I cannot remove For the record, Your other points hold and I have acted on what is in scope here: the keywords are down to |
d167777 to
c23da67
Compare
|
Note that this is a recent change, as evident by: https://github.com/agentskills/agentskills/pull/479/changes, we added these skills w/ metadata when it was first released, where it supported arbitrary key-value pairings, indeed these were all run through the validator during creation. |
b0b853a to
9990f1a
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9990f1a. Configure here.
| gh pr checks NNNN | ||
| ``` | ||
|
|
||
| An empty result means the checks do not exist yet and the loop keeps waiting. A PR that never settles has not started CI at all. |
There was a problem hiding this comment.
CI wait loop exits too early
High Severity
The draft-PR wait loop treats a pending count of 0 as “CI finished”, but gh pr checks --json prints [] when no checks have been scheduled yet. jq then prints 0, so the loop breaks immediately after open. The comment that an absent result keeps waiting does not apply: that case yields 0, not an empty string.
Reviewed by Cursor Bugbot for commit 9990f1a. Configure here.


🌟 What is the purpose of this PR?
Ships the Petrinaut shipping procedure as a repo skill so every agent session is offered it, following the skills layout from #9323. Stacked on #9391; the standing conventions the skill applies land in #9390.
🔗 Related links
🔍 What does this change?
petrinaut-shippingskill under.agents/skills/: the per-package gate commands, the changeset step, docs-sync pointers, pre-PR hygiene checks, and the draft-to-ready CI loop. Standing conventions stay in the packageAGENTS.mdand are referenced, not restated..claude/skills/petrinaut-shippingsymlink and regeneratesskill-rules.jsonwithyarn agents:skill-management generate-skill-rules.Review fixes:
petrinaut.changesetfuzzy-matched unrelated prompts through the hook's Levenshtein pass, so any monorepo changeset prompt pulled in this Petrinaut-only skill.files:block: the activation hook readspromptTriggersand neverfileTriggers, so those globs did nothing.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
yarn agents:skill-management validatepasses with the new skill.yarn workspace @local/claude-hooks test:unitpasses against the regenerated rules.❓ How to test this?
yarn agents:skill-management validateecho '{"session_id":"t","transcript_path":"/dev/null","cwd":".","permission_mode":"default","prompt":"fix a petrinaut lint failure and open a PR"}' | yarn workspace @local/claude-hooks run:skillpetrinaut-shippingappears under the recommended skills.🤖 Generated with Claude Code