Skip to content

FE-1507: Move the repertoire into core behind a guarded prompts subpath - #9349

Closed
lunelson wants to merge 5 commits into
ln/fe-1431-pluginsfrom
ln/fe-1507-topology
Closed

FE-1507: Move the repertoire into core behind a guarded prompts subpath#9349
lunelson wants to merge 5 commits into
ln/fe-1431-pluginsfrom
ln/fe-1507-topology

Conversation

@lunelson

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

ADR-0008 (accepted 2026-08-26) moves the harness's default teaching out of its own workspace and into core behind a guarded @hashintel/brunch-agent/prompts subpath that bindings may import and plugins may not. This branch is that mechanical move; it changes no plugin key and no repertoire text.

Draft: opened so the stack is visible end to end. The description is completed when the branch is tied off.

🔗 Related links

🚫 Blocked by

  • Stacks on ln/fe-1431-plugins; lands after it.

🔍 What does this change?

Removes packages/repertoire and its dependency edges; adds the ./prompts core export; the architecture suite requires the export and rejects a plugin import of it.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 28, 2026 12:47pm
petrinaut Ready Ready Preview Aug 28, 2026 12:47pm
petrinaut-docs Ready Ready Preview Aug 28, 2026 12:47pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Aug 28, 2026 12:47pm

Request Review

lunelson commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@lunelson
lunelson marked this pull request as ready for review August 26, 2026 17:19
@lunelson
lunelson requested a review from a team as a code owner August 26, 2026 17:19
@cursor

cursor Bot commented Aug 26, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
This changes package topology and every binding/evaluation import path for default prompt data, though guards and tests aim to keep plugins from importing harness teaching.

Overview
Implements ADR-0008 by deleting the @hashintel/brunch-agent-repertoire workspace and folding default harness teaching into @hashintel/brunch-agent as a new ./prompts subpath (prompts.ts loads validated repertoire.yaml). Bindings and the baseline evaluation now import repertoire from @hashintel/brunch-agent/prompts instead of the removed package.

Enforcement shifts with the move: architecture tests require the ./prompts export, assert no packages/repertoire, allow only bindings to import the subpath, and expect plugin oxlint to ban @hashintel/brunch-agent/prompts; the core root export must not re-export prompts. CI prune drops repertoire-specific extra paths/tests.

Docs (ADR-0008, topology, elicitation-kernel spec, steering) and plugin comments are updated to describe core-owned prompt data; repertoire content and plugin keys are unchanged.

Reviewed by Cursor Bugbot for commit 995a509. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/tests New or updated tests type/legal Owned by the @legal team labels Aug 26, 2026
lunelson and others added 5 commits August 28, 2026 14:32
Co-authored-by: Cursor <cursoragent@cursor.com>
The accepted record now exists on this branch, so the docs index and
steering file links can point at it. Drop the prune extra for the
removed repertoire workspace.

Co-authored-by: Cursor <cursoragent@cursor.com>
ADR-0008's architecture suite lives in core, so a plugin-only change never ran it. The plugin lint job is the gate that still fires then.

Co-authored-by: Cursor <cursoragent@cursor.com>
@lunelson

Copy link
Copy Markdown
Contributor Author

Superseded by merged PR #9463, which consolidated this branch and the rest of the FE-1406FE-1524 stack into one reviewed merge. Closing this PR as superseded; its discussion remains review history.

@lunelson lunelson closed this Aug 31, 2026
@lunelson
lunelson deleted the ln/fe-1507-topology branch August 31, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > frontend Owned by the @frontend team type/legal Owned by the @legal team

Development

Successfully merging this pull request may close these issues.

1 participant