Skip to content

Fix Core panicking on a zero-value Version #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgross merged 1 commit into from
Oct 13, 2026
Merged

Fix Core panicking on a zero-value Version #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,11 @@ func comparePrereleases(v string, other string) int {

// Core returns a new version constructed from only the MAJOR.MINOR.PATCH
// segments of the version, without prerelease or metadata.
// For a zero-value Version, Core returns 0.0.0.
func (v *Version) Core() *Version {
if len(v.segments) == 0 {
return Must(NewVersion("0.0.0"))
}
segments := v.Segments64()
segmentsOnly := fmt.Sprintf("%d.%d.%d", segments[0], segments[1], segments[2])
return Must(NewVersion(segmentsOnly))
Expand Down
14 changes: 14 additions & 0 deletions version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,3 +938,17 @@ func TestPrereleaseCompareIsTransitive(t *testing.T) {
t.Errorf("alpha.beta should be > alpha, got Compare = %d", c.Compare(a))
}
}

func TestCoreZeroValue(t *testing.T) {
var v Version
core := v.Core()
if got := core.String(); got != "0.0.0" {
t.Fatalf("Core() = %q, want 0.0.0", got)
}
if !core.Equal(&v) || core == &v {
t.Fatal("Core must return a new, equal version")
}
if len(v.segments) != 0 {
t.Fatal("Core mutated the receiver")
}
}
Loading