Repository navigation
feat(uat): create node keys with consensus keys init instead of sample secrets - #1283
Draft
leninmehedy wants to merge 1 commit into
Draft
leninmehedy wants to merge 1 commit into
leninmehedy wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
leninmehedy
added this pull request to stack #1201
October 13, 2026 12:59
…ple secrets Add a `keys` task to the daemon UAT harness that runs `consensus keys init` and `keys verify --from-cluster`. `uat:secrets` gets SAMPLE_KEYS (default true); the daemon `secrets` task sets it to false. `consensus` no longer passes fixed secret names, so install resolves the labelled secrets. Signed-off-by: Lenin Mehedy <lenin.mehedy@hashgraph.com>
leninmehedy
force-pushed
the
01169-uat-keys-task
branch
from
October 13, 2026 12:59
37c3d10 to
5f0d7ca
Compare
leninmehedy
marked this pull request as draft
October 20, 2026 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The daemon UAT (
docs/dev/daemon) used the fixedtest/sample-secretsfor node keys. This switches it to keys made withconsensus keys init, so the UAT exercises the real key flow.keystask: runsconsensus keys init, thenkeys verify --from-cluster, then lists the node's labelled secrets. Keys go toKEYS_DIR(default/tmp/cn-keys/node<N>); the admin private key stays there.uat:secretsgetsSAMPLE_KEYS(defaulttrue, so other callers are unchanged). The daemonsecretstask sets it tofalseand only creates pull secrets.SAMPLE_KEYS=truestill applies the sample secrets.consensustask no longer passes--signing-secret/--grpc-tls-secret. The old fixed names don't exist any more; install finds the labelled secrets itself.keys(T3b) and fixed thenetwork/consensustask-name drift.Stacked on #1281.
Test plan
task -d docs/dev/daemon --listparses both Taskfilesrebuild→cluster→secrets→keys→operator→consensus; node pod starts with the generated keysPart of #1164.
🤖 Generated with Claude Code