Skip to content

feat: export dist wasm files and package.json #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaledhosny merged 2 commits into from
Aug 25, 2026
Merged

feat: export dist wasm files and package.json #228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9ca262
feat: export dist wasm files and package.json
danielroe Aug 25, 2026
b5a31f2
Update package.json
danielroe Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
".": {
"types": "./dist/index.d.mts",
"default": "./dist/index.mjs"
}
},
"./dist/*.wasm": "./dist/*.wasm",
"./package.json": "./package.json"

@khaledhosny khaledhosny Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand .wasm, but what is package.json needed for?

@danielroe danielroe Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to drop it - I have no particular need of it, but added it as I often do in case people need to check the version of the package that is installed, e.g.:

import pkg from 'harfbuzzjs/package.json'

echo(pkg.version)

the alternative, should this be needed, is doing strange things to find the directory of the package, and then readFileSync - but of course this is theoretical as I guess no one's asked for this yet!

@khaledhosny khaledhosny Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop it then, please.

@lianghai lianghai Sep 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaledhosny, the package.json export was dropped but the PR’s title wasn’t revised, which made the automatically generated change log inaccurate: https://github.com/harfbuzz/harfbuzzjs/releases/tag/v1.6.1

Comment thread
danielroe marked this conversation as resolved.
Outdated
},
"files": [
"dist"
Expand Down
Loading