get_logbook: include canceled items alongside completed - #64
Open
ggfevans wants to merge 1 commit into
Open
Conversation
The Things Logbook contains both completed and canceled items; the tool previously queried status='completed' only, so canceled items were invisible. Fetch both statuses, merge, sort by stop_date.
jrelgin
added a commit
to jrelgin/things-mcp
that referenced
this pull request
Aug 9, 2026
CLAUDE.md gains a conflict-resolution table for merging upstream, and a three-way split of the fork's commits: PR-able (create_structured_project, tag management), never-PR (fork branding and the manifest git URL), and already-upstream (the three cherry-picked PRs). Calls out the non-obvious case: when hald merges hald#64/hald#65/hald#66, our cherry-picks conflict and should yield to upstream's version — but get_logbook contains a hand-merged region where hald#64 and hald#66 both rewrote the same call, so taking both wholesale lets one clobber the other. README points at it from the Development section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60.
The Things Logbook holds both completed and canceled items;
get_logbookqueriedstatus='completed'only, so canceled items were invisible. Fetch both statuses, merge, and keep the existing stop_date window filter, descending sort, and pagination/envelope unchanged.format_todoalready rendersStatus: canceled.Tests: 4 new (canceled items appear; merged sort by stop_date; period filter applies to canceled; both statuses queried with include_items); 5 existing logbook mocks converted to a status-keyed helper since the fix queries
things.tasksonce per status. Suite: 177 passed. The only failure is the pre-existing environmentaltest_construct_url_encodes_slash_in_values(callsthings.token()against a live Things DB, absent on Linux) — fails identically on unpatched master.Note: touches the same
things.taskscall site as the branch for #58 — a trivial one-line merge for whichever lands second.