fix dna nucleobase atom selection default for capri - #1661
Conversation
|
Something is not right with definition of U nucleotide (in all-atom): And then caprieval crushed the entire run |
|
Do we have any RNA-related tests/examples? If not probably good to add |
|
Technically that is separate issue that is not related to CG atom selection for DNA in capri, but while reading code in this PR, I spotted that in libalign, line 516 (definition of C in RNA_FULL_DICT):
|
|
Another potential issue is that DNA_FULL_DICT lists “O1P” and “O2P”, while haddock writes pdbs using “OP1” and “OP2”. I don’t think there’s any way to match those atoms within libalign or caprieval? |
| "P", | ||
| "O1P", | ||
| "O2P", | ||
| "OP1", |
There was a problem hiding this comment.
This is nice, but I initially did not think about the reference file. If that one is not being produced by haddock - then it can, in principle, contain O1P/O2P.
So maybe it’s better to keep all 4 options, same as scan.py in main is doing?
| "N9", | ||
| "C5", | ||
| "C6", | ||
| "O6", |
There was a problem hiding this comment.
RNA_FULL_DICT[“C”] has “O6” - should be “C6”:
| "O6", | |
| "C6", |
There was a problem hiding this comment.
I now copied quotes from the code directly - seems they are now not affected by this suggestion, but indeed beware!
|
You are introducing wrong quotes… beware!
|
|
One more thing - can you please update caprieval/defaults.yaml of ‘allatoms’ to say that backbone is the case for proteins and RNAs, but it’s nucleobases for DNAs? |
What does this PR do and why?
This PR modifies the default CG atom selection during
caprievalto select the nucelo-bases for DNA (l.316), matching the all-atom selection.AI assistance
Nope
Checklist
CHANGELOG.mdupdated for user-facing changesRelated issues
Closes #1658
Notes for reviewers
Sorry, the automatic linting program did not allow me to touch only the appropriate part, and I had to change the linting all along the script...