Add test for grounding validity - #85
Merged
Merged
Conversation
Collaborator
Author
|
When fixing invalid groundings for #74 I had accidentally uploaded some models with path names that are invalid on Windows. This should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
This PR adds a test that all groundings produced by Adeft are valid identifiers. The test relies on
indra.statements.validate, so INDRA has been added as an optional test dependency. We can go further and check consistency between name and grounding or other things like that, but this will at least catch examples like those seen in #74. I've updated all of the models on S3 so that this test passes. CI passing here should confirm that #74 can now be closed.