Fix memory leaks in adeft scorer C extension - #84
Merged
Conversation
Collaborator
Author
|
I'm going to go ahead and merge this. After also addressing #74 I'll cut a new Adeft release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While training Adeft models I noticed very large memory utilization, particularly for very frequent shortforms appearing in many texts. The pattern was suspicious, so I investigated with
tracemallocin a Python script and found the memory usage was occurring inadeft/scoring._score.cgenerated fromadeft/scoring/_score.pyx. Further investigation with Valgrind found some mallocs missing an associated free. There were also some mallocs wheresizeofwas applied to the wrong type thatValgrindidentified that I've also fixed. The patch in this PR dramatically reduced memory consumption, making the full Adeft model training process feasible to run out on my home workstation.