Skip to content

docs: cold review before the push - #256

Merged
gurinderu merged 2 commits into
mainfrom
docs/review-before-push
Oct 23, 2026
Merged

gurinderu merged 2 commits into
mainfrom
docs/review-before-push

Conversation

@gurinderu

Copy link
Copy Markdown
Owner

The repository's own order for a finished branch becomes cold review → push → PR (realm @nick/craft, #127): the reviewer reads the local branch at its commit, blocking findings close before the push. No hook can guard this order — a hook's context reaches the model only after the command (#289) — so AGENTS.md says the order is the agent's to hold, and the post-push line only catches a push that came first. reviewer.md reads the local branch, falling back to origin for release-please's PR. A deliberate divergence from the iskronify template, named in AGENTS.md.

Dropped Low findings:

  • The shipped plugin's push line (lib/push-hook.mjs) counts only craft:review/adversarial-review records, not the reviewer role's verdict, so in this repo it may still speak after a reviewed push.

@gurinderu
gurinderu merged commit 5deb272 into main Oct 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant