Repository navigation
docs: cold review before the push - #256
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository's own order for a finished branch becomes cold review → push → PR (realm @nick/craft, #127): the reviewer reads the local branch at its commit, blocking findings close before the push. No hook can guard this order — a hook's context reaches the model only after the command (#289) — so AGENTS.md says the order is the agent's to hold, and the post-push line only catches a push that came first. reviewer.md reads the local branch, falling back to origin for release-please's PR. A deliberate divergence from the iskronify template, named in AGENTS.md.
Dropped Low findings: