Add explain endpoint for dev and fix not_exists query - #974
Draft
bryophyta wants to merge 5 commits into
Draft
Conversation
According to the Postgres docs, `NOT NULL` evaluates to `NULL`, rather than `TRUE`. But if we're saying "doesn't include x, y, z category codes", for instance, then we would want this to be `TRUE` for a row which had `category_codes: NULL`. So we should use `(clause) IS NOT TRUE` instead of `NOT (clause)`. https://www.postgresql.org/docs/17/functions-logical.html#FUNCTIONS-LOGICAL
bryophyta
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
NOT EXISTSquery variant, meaning that it should now be logically equivalent to thePLAIN NOTvariant (as it should have been when the latter was first introduced).How to test
Images
Introducing DB migrations?
Database migrations need to be applied manually before releasing. The docs can be found in db/README.md