Make supplier and other array params mandatory - #476
Open
bryophyta wants to merge 2 commits into
Open
Conversation
bryophyta
changed the base branch from
main
to
pf/separate-layout-component-for-ticker
September 22, 2025 10:42
bryophyta
force-pushed
the
pf/array-search-params-mandatory
branch
from
September 22, 2025 10:45
ecd8021 to
3edee35
Compare
bryophyta
force-pushed
the
pf/separate-layout-component-for-ticker
branch
from
September 22, 2025 15:20
4665893 to
4984511
Compare
bryophyta
force-pushed
the
pf/array-search-params-mandatory
branch
from
September 22, 2025 15:23
3edee35 to
cae3791
Compare
lindseydew
reviewed
Sep 22, 2025
lindseydew
left a comment
lindseydew
left a comment
Contributor
There was a problem hiding this comment.
Nice, this is looking like a good shout 🙌
Just had a question about the test set up
| expect(config).toEqual({ | ||
| view: 'feed', | ||
| query: { | ||
| ...defaultQuery, |
Contributor
There was a problem hiding this comment.
How come ...defaultQuery is being passed in twice here?
Contributor
Author
There was a problem hiding this comment.
good catch, thanks! just a copy-paste error I think 🤦 I've fixed it now 👍
Base automatically changed from
pf/separate-layout-component-for-ticker
to
main
September 23, 2025 07:43
bryophyta
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
We have a number of search parameters in the UI that take arrays, which are currently optional. There's no clear meaning in this context for 'undefined', as opposed to an empty array, though, and we almost always expected the values to be arrays (empty or otherwise), so it makes sense to make sure it's always an array, so that the code is simpler (fewer checks to make sure it's an array) and easier to reason about.
How to test
Images
Introducing DB migrations?