Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 8, 2026 22:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing a configuration dictionary such as
{'path': r'C:\new\report.csv'}currently inserts a newline into the displayed path. The genericargumentToString()replaces every backslash-n substring in pretty-printed output, including one that follows an already escaped backslash.Consume escaped backslash pairs before converting a remaining newline escape. This preserves literal backslashes inside containers, bytes/bytearrays, and custom representations while retaining the existing rendering of real newlines and pretty-print wrapping. Top-level string dispatch is unchanged.
Five regression tests cover public
ic()output, nested containers, odd/even backslash counts, bytes, custom repr, quotes and CRLF. All five fail against the original implementation (11 failing assertions/subtests).Validation on Linux / CPython 3.12.14:
git diff --checkpassed.Related to the path-display reports in #130/#206. I checked #228: it changes the registered string formatter, whereas this fix concerns the generic formatter used for containers and other values. This does not claim to resolve the broader output-policy questions in #220.
AI assistance was used to prepare the implementation and regression tests. The hosted Python/OS matrix has not been run locally.