Repository navigation
Support scoped enable and disable context managers - #250
Open
jackwalkerlabs wants to merge 1 commit into
Open
jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
Fixes gruns#125. Implemented and validated with Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ic.enable()andic.disable()now supportwithblocks that restore the previous enabled state on exit. Ordinary calls still change the state immediately. Nested blocks and exceptions restore the enclosing state, and the README shows the scoped usage.Fixes #125, following the proposed return-a-context-manager approach in the discussion.
Validation: all 68 unittest tests pass on Python 3.12/macOS; Mypy checks all five source files. The three new tests fail on the original implementation and cover both initial states, nesting, and exception propagation.
Implemented and tested using Codex under the submitting account's authorization.