Repository navigation
Display control chars and invisible Unicode explicitly (#220) - #228
AJTimePyro wants to merge 5 commits into
Conversation
|
Thank you! That looks promising! I'll take a look. |
|
cool, let me know if there's any issue or something,... i will change accordingly |
|
@AJTimePyro I think it would be nice to have test covered this one. Do you think you could do that? Keep in mind, that recently I merged tests refactoring (in PEP8 style). |
|
I can try to create some test |
|
@Jakeroid I have added some tests, you can check them out. |
|
@AJTimePyro Tests are failed. Could you take a look please? |
|
@AJTimePyro Oh, I know why. Because of recent refactoring which was did here: #223 Do you think you could fix issues by keeping refactoring in place? |
|
oh okay i will fix it soon |
|
@AJTimePyro awesome thank you! |
|
@AJTimePyro How is it going? |
|
@Jakeroid Hey man, first of all I am really sorry that I didn't worked on it after our last conversation. Now I have updated PR to keep up with latest branch, and also tested locally and all tests clear, you can do your manual review and let me know if you there's still room for improvement or anything. Thanks for your patience. |
This pull request improves how
argumentToStringconverts strings by making escaping safer and more predictable, especially for edge cases that were previously mishandled. Inspired from issue #220What changed: