Fix php build and upgrade to php8 - #425
Open
arjan-bal wants to merge 4 commits into
Open
Conversation
arjan-bal
marked this pull request as ready for review
August 6, 2026 05:42
Contributor
Author
pawbhard
approved these changes
Aug 10, 2026
pawbhard
left a comment
pawbhard
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for doing this
Contributor
Author
|
I will verify the changes integrate correctly with the changes to re-introduce PHP to the CI in the grpc/grpc repository before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While verifying that all images build successfully for the next release, I found that apt has stopped working on Debian Buster images. While running the PHP tests with the Debian Bullseye base image, I discovered that the workers were not compiled and linked correctly. Since Protobuf dropped support for PHP 7, I needed to bump the version to PHP 8. This PR fixes the build and updates all PHP 7 references to PHP 8.
Tested
Verified that pre-built tests pass and on-the-fly test workers run. (Note: The on-the-fly test currently fails due to a timeout caused by slow gRPC compilation.)