Skip to content

Enable support for Editions in protoc-gen-grpc-web. #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampajano merged 3 commits into from
Aug 20, 2025
Merged

Enable support for Editions in protoc-gen-grpc-web. #1490

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6a17e7
Enable support for Editions in protoc-gen-grpc-web.
Quarke Aug 19, 2025
f9c4e3a
Update grpc_generator.cc with comment linking edition support to prot…
Quarke Aug 20, 2025
cb2efd0
Merge branch 'master' into patch-1
Quarke Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion javascript/net/grpc/web/generator/grpc_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <string>

using google::protobuf::Descriptor;
using google::protobuf::Edition;
using google::protobuf::EnumDescriptor;
using google::protobuf::FieldDescriptor;
using google::protobuf::FileDescriptor;
Expand Down Expand Up @@ -1522,9 +1523,12 @@ class GrpcCodeGenerator : public CodeGenerator {

uint64_t GetSupportedFeatures() const override {
// Code generators must explicitly support proto3 optional.
return CodeGenerator::FEATURE_PROTO3_OPTIONAL;
return CodeGenerator::FEATURE_PROTO3_OPTIONAL | CodeGenerator::FEATURE_SUPPORTS_EDITIONS;
}

Edition GetMinimumEdition() const override { return Edition::EDITION_PROTO2; }
Edition GetMaximumEdition() const override { return Edition::EDITION_2023; }
Comment thread
sampajano marked this conversation as resolved.

bool Generate(const FileDescriptor* file, const string& parameter,
GeneratorContext* context, string* error) const override {
GeneratorOptions generator_options;
Expand Down