test: enable webpki TLS feature for test - #2805
Open
arjan-bal wants to merge 1 commit into
Open
Conversation
dfawley
approved these changes
Aug 14, 2026
dfawley
left a comment
Member
There was a problem hiding this comment.
Should we change the CI to not pass --all-features when running tests to ensure that a bare cargo test will continue to pass?
Contributor
Author
|
If we don't use |
Member
|
Is it too much of a waste to run both with and without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2801
This change enables the
tls-webpki-rootsfeature for integration tests that verify the identity ofgithub.com.This issue wasn't caught by CI because our CI configuration currently builds with all feature flags enabled. Please see the attached issue for details on the root cause.
Tested
Verified that
cargo teston the workspace root works.