Skip to content

test: enable webpki TLS feature for test - #2805

Open
arjan-bal wants to merge 1 commit into
grpc:masterfrom
arjan-bal:debug-test
Open

test: enable webpki TLS feature for test#2805
arjan-bal wants to merge 1 commit into
grpc:masterfrom
arjan-bal:debug-test

Conversation

@arjan-bal

@arjan-bal arjan-bal commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Fixes: #2801

This change enables the tls-webpki-roots feature for integration tests that verify the identity of github.com.

This issue wasn't caught by CI because our CI configuration currently builds with all feature flags enabled. Please see the attached issue for details on the root cause.

Tested

Verified that cargo test on the workspace root works.

@arjan-bal
arjan-bal requested a review from dfawley August 14, 2026 07:17
@arjan-bal arjan-bal added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 14, 2026

@dfawley dfawley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the CI to not pass --all-features when running tests to ensure that a bare cargo test will continue to pass?

@LucioFranco?

@arjan-bal

Copy link
Copy Markdown
Contributor Author

If we don't use --all-features, unit tests for non-default features would get skipped. For example, the compression tests that require optional codecs would not run.

@dfawley

dfawley commented Aug 14, 2026

Copy link
Copy Markdown
Member

Is it too much of a waste to run both with and without --all-features? I'm thinking the only way we can guarantee that potential contributors will be able to come to our repo and run cargo test and see a pass is if we run it that way in CI.

@dfawley dfawley assigned arjan-bal and unassigned dfawley Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo test fails on 70c78a7854577bc78e31623d699b9331eb84c192 (current master)

2 participants