fix: prevent pagination buttons from submitting forms - #1513
Open
sridharkalaibala wants to merge 1 commit into
Open
sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pagination buttons default to submitting their surrounding form. A grid embedded in a form can change page and then immediately submit/reload the page, including when an ellipsis is clicked.
Change
Set
type="button"on every pagination button: previous/next, page numbers, first/last shortcuts, and both ellipses. No event suppression or changes to page-selection logic are needed.Fixes #1248. The earlier #1268 was closed without merging; the issue remains on current master.
Validation
.click(). All three fail before the fix because submit events fire, and pass afterward.type="button"attributes were added.git diff --checkpass.