Skip to content

updated minimum required cmake version to 3.16 #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gullradriel wants to merge 1 commit into from
Closed

updated minimum required cmake version to 3.16 #1514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firmware/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

# Top directory CMake project for HackRF firmware

cmake_minimum_required(VERSION 3.1.3)
cmake_minimum_required(VERSION 3.16)
set(CMAKE_TOOLCHAIN_FILE toolchain-arm-cortex-m.cmake)

project (hackrf_firmware_all C)
Expand Down
2 changes: 1 addition & 1 deletion firmware/blinky/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# Boston, MA 02110-1301, USA.
#

cmake_minimum_required(VERSION 3.1.3)
cmake_minimum_required(VERSION 3.16)
set(CMAKE_TOOLCHAIN_FILE ../toolchain-arm-cortex-m.cmake)

project(blinky C)
Expand Down
2 changes: 1 addition & 1 deletion firmware/hackrf_usb/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Boston, MA 02110-1301, USA.
#

cmake_minimum_required(VERSION 3.1.3)
cmake_minimum_required(VERSION 3.16)
set(CMAKE_TOOLCHAIN_FILE ../toolchain-arm-cortex-m.cmake)

project(hackrf_usb C)
Expand Down
2 changes: 1 addition & 1 deletion host/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#top dir cmake project for libhackrf + tools

cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.16)

@LecrisUT LecrisUT Jul 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmake_minimum_required(VERSION 3.16)
cmake_minimum_required(VERSION 2.8...4.0)

If upstream wants to preserve compatibility this is how. Although if it's not tested with the lower end, there can be incompatible changes creeping in.

On the other hand for the users with very old CMake, wouldn't they also be using a very old version of this project? If they are building from source it is also trivial to get a modern cmake:

$ pip install cmake

project (HackRF C)

set(CMAKE_C_FLAGS "$ENV{CFLAGS}" CACHE STRING "C Flags")
Expand Down
2 changes: 1 addition & 1 deletion host/hackrf-tools/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

# Based heavily upon the libftdi cmake setup.

cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.16)
project(hackrf-tools C)
set(PACKAGE hackrf-tools)
include(${PROJECT_SOURCE_DIR}/../cmake/set_release.cmake)
Expand Down
2 changes: 1 addition & 1 deletion host/libhackrf/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

# Based heavily upon the libftdi cmake setup.

cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.16)
project(libhackrf C)
set(MAJOR_VERSION 0)
set(MINOR_VERSION 9)
Expand Down