feat(design, design-examples, daffio, demo): deprecate @daffodil/design/image in favor of @daffodil/design/image-lite - #4683
Open
xelaint wants to merge 2 commits into
Open
feat(design, design-examples, daffio, demo): deprecate @daffodil/design/image in favor of @daffodil/design/image-lite#4683xelaint wants to merge 2 commits into
@daffodil/design/image in favor of @daffodil/design/image-lite#4683xelaint wants to merge 2 commits into
Conversation
…ign/image` in favor of `@daffodil/design/image-lite`
xelaint
added
the
status: blocked
xelaint
changed the title
@daffodil/design/image in favor of @daffodil/design/image-lite
Member
Author
|
@damienwebdev #4681 needs to be approved and merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Part of: #4674
New behavior
DaffImageComponentandDAFF_IMAGE_COMPONENTShave been deprecated in version 0.95.0 and will be removed in version 0.101.0, along with the already deprecatedDaffImageModule.Migrated every usage to
img[daff-image]from@daffodil/design/image-lite.Because image-lite applies directly to the
imgelement rather than wrapping it in a host element, the styles that compensated for that wrapper are no longer needed:overflow: hiddenon.daff-card__image, and the flex centering on the media gallery's selected thumbnail.Blocked by #4681
Breaking change?
Additional context