Fix problems in pull derivation - #326
Draft
DeSevilla wants to merge 2 commits into
Draft
Conversation
DeSevilla
marked this pull request as draft
April 10, 2026 04:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "pull" builtin, which derives its semantics from the type it's applied to, has some problems in the derivation for arbitrary type constructors, which cause execution errors (incomplete pattern match) as noted in #278 and #316 . This PR fixes those issues and adds more thorough tests for pull. I'm marking it as a draft because I'm uncertain about a few semantic aspects and would like feedback on my code structure.
The problems are: