Fix: make label names uniform - #596
Open
mem wants to merge 1 commit into
Open
Conversation
Our use of labels names in logs and metrics is not uniform and this is causing a lot of pain. We have `foo_id`, `fooID` and other variations. Pick one. It's `fooId` from now on. It's going to be painful to change everywhere else to match this, but it's better than dealing with the existing pain. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
rdubrock
approved these changes
Jan 31, 2024
Member
|
So from now on we use camelCase for log labels, but we should keep using snake_case for prom labels, right? |
Contributor
Author
I didn't think that far, but sounds reasonable. Basically I looked at what would introduce the least changes, and camel case for log labels won. |
nadiamoe
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our use of labels names in logs and metrics is not uniform and this is causing a lot of pain.
We have
foo_id,fooIDand other variations.Pick one.
It's
fooIdfrom now on.It's going to be painful to change everywhere else to match this, but it's better than dealing with the existing pain.