feat(plugins): Hermes agent plugin - #776
Merged
Merged
Conversation
alexander-akhmetov
force-pushed
the
alexander/move-hermes-plugin-agento11y
branch
from
September 18, 2026 14:40
24107fe to
e0019f6
Compare
alexander-akhmetov
force-pushed
the
alexander/move-hermes-plugin-agento11y
branch
from
September 18, 2026 19:16
e0019f6 to
ed45f32
Compare
alexander-akhmetov
force-pushed
the
alexander/move-hermes-plugin-agento11y
branch
from
September 19, 2026 00:50
ed45f32 to
67731e2
Compare
alexander-akhmetov
marked this pull request as ready for review
September 23, 2026 11:37
alexander-akhmetov
force-pushed
the
alexander/move-hermes-plugin-agento11y
branch
from
September 23, 2026 11:42
67731e2 to
4f51b6d
Compare
soniaAguilarPeiron
left a comment
Collaborator
There was a problem hiding this comment.
from my GPT-5.6 Sol colleague 😄
-
Medium — OTel-only setups can be disabled. The activation gate ignores host-provided OTel providers, while invalid optional generation auth permanently disables all hooks. Detect existing providers and fall back to generation export
none. -
Medium — Turn completion can block for minutes.
on_session_endperforms an unbounded synchronous flush with multiple 30-second retries. Use a bounded asynchronous flush. -
Medium — Legacy version is missing from
agent_version.AGENTO11Y_HERMES_AGENT_VERSIONonly populateseffective_version, splitting generation and metric identity. Resolve once and set both fields.
Collaborator
Author
|
I can do some of the fixes as a follow-up, this is just the first PR. |
soniaAguilarPeiron
approved these changes
Sep 23, 2026
alexander-akhmetov
deleted the
alexander/move-hermes-plugin-agento11y
branch
September 23, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first PR to migrate https://github.com/alexander-akhmetov/grafana-agento11y-hermes to grafana/agento11y