Skip to content

feat(plugins): Hermes agent plugin - #776

Merged
alexander-akhmetov merged 1 commit into
mainfrom
alexander/move-hermes-plugin-agento11y
Sep 23, 2026
Merged

alexander-akhmetov merged 1 commit into
mainfrom
alexander/move-hermes-plugin-agento11y

Conversation

@alexander-akhmetov

@alexander-akhmetov alexander-akhmetov commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

The first PR to migrate https://github.com/alexander-akhmetov/grafana-agento11y-hermes to grafana/agento11y

cursor[bot]

This comment was marked as outdated.

@alexander-akhmetov
alexander-akhmetov force-pushed the alexander/move-hermes-plugin-agento11y branch from 24107fe to e0019f6 Compare September 18, 2026 14:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread plugins/hermes/src/grafana_agento11y_hermes/_hooks.py Outdated
@alexander-akhmetov
alexander-akhmetov force-pushed the alexander/move-hermes-plugin-agento11y branch from e0019f6 to ed45f32 Compare September 18, 2026 19:16
cursor[bot]

This comment was marked as outdated.

@alexander-akhmetov
alexander-akhmetov force-pushed the alexander/move-hermes-plugin-agento11y branch from ed45f32 to 67731e2 Compare September 19, 2026 00:50
@alexander-akhmetov
alexander-akhmetov marked this pull request as ready for review September 23, 2026 11:37
@alexander-akhmetov
alexander-akhmetov requested a review from a team September 23, 2026 11:37
@alexander-akhmetov
alexander-akhmetov force-pushed the alexander/move-hermes-plugin-agento11y branch from 67731e2 to 4f51b6d Compare September 23, 2026 11:42

@soniaAguilarPeiron soniaAguilarPeiron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my GPT-5.6 Sol colleague 😄

  • Medium — OTel-only setups can be disabled. The activation gate ignores host-provided OTel providers, while invalid optional generation auth permanently disables all hooks. Detect existing providers and fall back to generation export none.

  • Medium — Turn completion can block for minutes. on_session_end performs an unbounded synchronous flush with multiple 30-second retries. Use a bounded asynchronous flush.

  • Medium — Legacy version is missing from agent_version. AGENTO11Y_HERMES_AGENT_VERSION only populates effective_version, splitting generation and metric identity. Resolve once and set both fields.

@alexander-akhmetov

Copy link
Copy Markdown
Collaborator Author

I can do some of the fixes as a follow-up, this is just the first PR.

@alexander-akhmetov
alexander-akhmetov merged commit fd68c43 into main Sep 23, 2026
47 checks passed
@alexander-akhmetov
alexander-akhmetov deleted the alexander/move-hermes-plugin-agento11y branch September 23, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants