Skip to content

feat(guardian): introduce new guardian jobs #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahmatrhd wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(guardian): introduce new guardian jobs #32

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f18834
feat(guardian): introduce new guardian jobs
rahmatrhd Aug 1, 2023
fe4800b
chore: update existing jobs name
rahmatrhd Aug 2, 2023
b5fd987
fix: update job config env
rahmatrhd Aug 30, 2023
f9e6e51
chore: add minimal guardian version that support the new jobs
rahmatrhd Aug 30, 2023
e29eddf
fix: shorten job name to avoid max 52 characters job name error
rahmatrhd Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stable/guardian/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.0
version: 0.2.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.3.0"
appVersion: "0.3.0" # TODO: update with latest version

dependencies:
- name: app
Expand Down
18 changes: 18 additions & 0 deletions stable/guardian/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,22 @@ app:
- job
- run
- appeal_expiration_revocation

@bsushmith bsushmith Aug 1, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the appeal expiration related jobs also to grant related ones.

@rahmatrhd rahmatrhd Aug 2, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

- name: "inactive-user-revocation"
schedule: "0 7 * * *"
restartPolicy: Never
command: []
args:
- job
- run
- revoke_grants_by_user_criteria
- name: "grant-dormancy-check"
schedule: "0 8 * * *"
restartPolicy: Never
command: []
args:
- job
- run
- grant_dormancy_check

ingress:
enabled: true
Expand All @@ -85,6 +101,8 @@ app:
JOBS_REVOKE_EXPIRED_ACCESS_INTERVAL: "*/20 * * * *"
JOBS_EXPIRING_ACCESS_NOTIFICATION_ENABLED: false
JOBS_EXPIRING_ACCESS_NOTIFICATION_INTERVAL: "0 9 * * *"
Comment on lines 101 to 103

@bsushmith bsushmith Aug 1, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add grant related flags also here?

@rahmatrhd rahmatrhd Aug 2, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are optional, we can omit them from here

@bsushmith bsushmith Aug 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Some of these existing ones are deprecated if I recall correctly. Can we remove the deprecated ones also.

JOBS_REVOKE_GRANTS_BY_USER_CRITERIA_CONFIG_DRY_RUN: true
JOBS_GRANT_DORMANCY_CHECK_CONFIG_DRY_RUN: true


secretConfig:
Expand Down