feat: auto-redirect to OIDC IdP (#991) - #1029
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
+ Coverage 74.78% 75.47% +0.69%
==========================================
Files 66 66
Lines 3541 3556 +15
==========================================
+ Hits 2648 2684 +36
+ Misses 688 662 -26
- Partials 205 210 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
69d7eb8 to
d764fd9
Compare
jmattheis
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
|
Im pretty confident the prompt params are correct and to spec, but I'm having trouble testing value combinations, it seems I have discovered a bug in authelia 🤷♂️ I will test mutliple prompt values against one of my dev keycloak instances later, but configuring keycloak is always such a pain in the a**, I doint have time for that right now |
5ae0c1e to
82856b6
Compare
|
I've made some changes, notably:
I'll test this some more this week. |
|
I've tested with dex, authelia, keycloak and authentik. Authentik didn't seem to use the prompt parameter, but didn't error when it was set. I tried using multiple prompt values like |
This PR attempts to implement the missing part of #991
Add GOTIFY_OIDC_AUTO_REDIRECT (with default
false) to skip the login page and redirect straight to the configured OIDC provider. Only takes effect when local auth is disabled, since local login would otherwise be unreachable.Add GOTIFY_OIDC_AUTO_REDIRECT_REQUIRE_REAUTH (default false) to send prompt=login on that redirect, so logging out of Gotify doesn't silently log the user back in via an existing IdP session. Does not end that IdP session, so other apps using it are unaffected.
Wire both flags through gotifyinfo/injected UI config and the WebUI login page, which now redirects instead of showing the OIDC button when enabled.
Added helperfunction to emit warnigns via FutureLog in config builder/parser