refactor: consolidate all LLM prompts into a single folder - #3885
Open
SurajsinghBayas wants to merge 2 commits into
Open
refactor: consolidate all LLM prompts into a single folder#3885SurajsinghBayas wants to merge 2 commits into
SurajsinghBayas wants to merge 2 commits into
Conversation
Move all LLM prompt files from separate feature-specific directories (data/nl2q/, data/llm_summarize/, data/llm_starred_events_report/) into a single unified data/llm_prompts/ directory. This makes it easier to discover, configure and maintain all prompts from one place as the number of LLM features in Timesketch grows. Changes: - Add data/llm_prompts/ with all 6 prompt files + README.md - Rename prompt files to be self-descriptive (e.g. nl2q_prompt.txt) - Update timesketch.conf config keys to point to new paths - Update docker/dev/build/docker-entrypoint.sh to symlink new folder - Update contrib/deploy_timesketch.sh download paths - Update docs/guides/admin/llm-features.md documentation - Update testlib.py and all affected test files Closes google#3708
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3708
As the number of LLM-powered features in Timesketch grows, having
separate directories for every prompt (data/nl2q/, data/llm_summarize/,
data/llm_starred_events_report/) creates maintenance overhead.
This PR consolidates all LLM prompt files into a single unified
data/llm_prompts/directory with descriptive filenames.Changes
data/llm_prompts/with all 6 prompt files + README.mdtimesketch.conf— all config keys point to new pathsdocker/dev/build/docker-entrypoint.sh— 3 symlinks → 1contrib/deploy_timesketch.sh— new curl pathsdocs/guides/admin/llm-features.md— reflects new structuretestlib.pyand all 3 affected test setUp() pathsdata/nl2q/,data/llm_summarize/,data/llm_starred_events_report/Testing
All existing unit tests in
nl2q_test.py,llm_summarize_test.py, andllm_starred_events_report_test.pywere updated to reference the new paths.