feat: make the tool status be the bottom element with new messages at top - #1067
Open
seankmartin wants to merge 1 commit into
Open
feat: make the tool status be the bottom element with new messages at top#1067seankmartin wants to merge 1 commit into
seankmartin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #991 we use a tool which is on the screen very commonly, and the status message system to inform about edits made. The kind of thing like - if a merge is performed correctly, or if the merge fails, or if you have the wrong permissions to move a node.
When this happens the tool message visually shifts around because the status messages are getting appended to the bottom of the list. This PR aims to change this behaviour, so tools are always appended at the bottom of the element list, and messages instead get prepended and put as the first element in the list.
So while you could previously get this where the tools are in between messages, or the message shows below the tool and moves the tool up visually

Now you always get it like:

with the tool fixed at the bottom and messages above.
I'm making this PR as a general one because I think it could be helpful for review purposes of #991 if these kind of general changes are not baked inside that PR and can be more easily discussed in smaller pieces where possible. And because if other tools are ever using the same system, it could be helpful.