Repository navigation
fix: respect module boundaries when clearing imports - #830
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursive module selection uses a raw string-prefix match, so clearing a package named
foocan also removefoo_extraand its children fromsys.modules. This affectsclear_cached_modulesand its reload callers.Match exact requested module names or names beginning with the requested name plus a dot. Tests cover recursive and non-recursive selection, multiple roots, empty selection, and actual cache clearing while retaining a similarly named sibling.
Validation: both new tests fail before the change; all three adhoc utility tests pass afterward.
git diff --checkpasses. Pyink accepts the tests; it requests only pre-existing formatting of the path-normalization expression in the implementation file.