Skip to content

resctrl: return 0 for AMD when we get Unavailable stats #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dqminh wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

resctrl: return 0 for AMD when we get Unavailable stats #3928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions resctrl/intel/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,14 @@ func readStatFrom(path string, vendorID string) (uint64, error) {
contextString := string(bytes.TrimSpace(context))

if contextString == unavailable {
err := fmt.Errorf("\"Unavailable\" value from file %q", path)
if vendorID == "AuthenticAMD" {
kernelBugzillaLink := "https://bugzilla.kernel.org/show_bug.cgi?id=213311"
err = fmt.Errorf("%v, possible bug: %q", err, kernelBugzillaLink)
// AMD can return Unavailable when it does not have any data (i.e. no tasks ran on the group)
// It's better to return 0 and let user have metrics/deal with it rather
// than return errors and failing the collection
// See https://bugzilla.kernel.org/show_bug.cgi?id=213311
return 0, nil
}
return 0, err
return 0, fmt.Errorf("\"Unavailable\" value from file %q", path)
}

stat, err := strconv.ParseUint(contextString, 10, 64)
Expand Down