Fix embedded form dropdown scroll propagation - #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564.
What changed
Evidence
The live headed Chrome reproduction moved the host page 646-811px. Runtime isolation showed suppressing focus did not stop it, while suppressing cmdk selected-item scrollIntoView (or scoping it to the nearest container) did. This matches the upstream cmdk report and proposed fix:
The local implementation preserves keyboard navigation by adjusting only the command list scrollTop, including long-list upward and downward movement.
Focused verification
Per request, the broad repository test suites were not run locally and are left to CI.