Skip to content

Fix embedded form dropdown scroll propagation - #565

Merged
jackmusick merged 2 commits into
mainfrom
564-embedded-form-scroll
Aug 8, 2026
Merged

Fix embedded form dropdown scroll propagation#565
jackmusick merged 2 commits into
mainfrom
564-embedded-form-scroll

Conversation

@jackmusick

Copy link
Copy Markdown
Collaborator

Fixes #564.

What changed

  • constrain cmdk selected-item scrolling to the nearest command list instead of allowing native scrollIntoView to traverse the iframe boundary
  • focus the post-submit confirmation with preventScroll
  • add a self-contained cross-origin iframe regression for the consecutive Company Size / How did you hear about us sequence

Evidence

The live headed Chrome reproduction moved the host page 646-811px. Runtime isolation showed suppressing focus did not stop it, while suppressing cmdk selected-item scrollIntoView (or scoping it to the nearest container) did. This matches the upstream cmdk report and proposed fix:

The local implementation preserves keyboard navigation by adjusting only the command list scrollTop, including long-list upward and downward movement.

Focused verification

  • TypeScript build: passed
  • ESLint on touched files: passed
  • Command, FormConfirmation, and form MultiCombobox tests: 11 passed
  • Cross-origin physical-click Playwright regression: passed 3/3 consecutive repetitions

Per request, the broad repository test suites were not run locally and are left to CI.

@jackmusick
jackmusick added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit 6b9d318 Aug 8, 2026
16 checks passed
@jackmusick
jackmusick deleted the 564-embedded-form-scroll branch August 8, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Prevent embedded form dropdowns from scrolling the host page

1 participant