Use constant-time comparison for secret key in SecretKeyFilter - #24888
Open
bunlongheng wants to merge 1 commit into
Open
Use constant-time comparison for secret key in SecretKeyFilter#24888bunlongheng wants to merge 1 commit into
bunlongheng wants to merge 1 commit into
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed SecretKeyFilter compares the incoming token against settings.SECRET_KEY with a plain
==. That filter hands back the full queryset (bypassing object-level perms) when the key matches, and it's wired into the crypto and brands APIs, so the comparison is worth doing in constant time to avoid leaking anything through timing.The rest of the codebase already does this - token_secret_key in authentik/api/authentication.py uses hmac.compare_digest for the exact same SECRET_KEY check, so this just brings the filter in line with that.
Behavior is unchanged for a correct key, and the None guard stays in front so we never hand compare_digest a null token.