web: keep the search-select dropdown inside its modal (cherry-pick #24812 to version-2026.8) - #24884
Open
authentik-cherry-pick[bot] wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version-2026.8 #24884 +/- ##
==================================================
+ Coverage 90.83% 91.47% +0.64%
==================================================
Files 1149 1149
Lines 72334 72334
Branches 3875 3875
==================================================
+ Hits 65704 66167 +463
+ Misses 6595 6132 -463
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
kensternberg-authentik
approved these changes
Aug 10, 2026
kensternberg-authentik
left a comment
kensternberg-authentik
left a comment
Contributor
There was a problem hiding this comment.
Just a question: Can we restore the flip-above behavior? Why/why not? If the control is near the bottom of a modal that fills most of the viewport vertically, it's gonna be messy.
* web: keep search-select popover inside its dialog and dedupe file upload entry points Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * web: prevent focus auto-scroll from shifting the search-select anchor while placing the menu Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * web: always place the search-select menu below its anchor Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * web: add back --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
GirlBossRush
force-pushed
the
cherry-pick/24812-to-version-2026.8
branch
from
August 11, 2026 13:57
a65ea81 to
e562fc5
Compare
GirlBossRush
enabled auto-merge (squash)
August 11, 2026 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #24812 to
version-2026.8branch.Original PR: #24812
Original Author: @dominic-r
Cherry-picked commit: 2c9b624