events: use absolute URLs (constructed using base_url from the tenant) when sending notifications outside (e.g. via email) - #24877
Open
atereshkin wants to merge 1 commit into
Conversation
…) when sending notifications outside (e.g. via email)
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atereshkin
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24877 +/- ##
==========================================
- Coverage 91.37% 91.35% -0.03%
==========================================
Files 1137 1138 +1
Lines 71591 71691 +100
Branches 3875 3875
==========================================
+ Hits 65417 65490 +73
- Misses 6139 6166 +27
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
What does this PR change?
This makes notifications containing a hyperlink use absolute URLs when they are going outside of the system (i.e. via email, Slack or webhook).
Why is this change needed?
We've added an ability to include a hyperlink in notifications earlier but it was useless for external notifications because those hyperlinks were relative URLs.
How was this tested?
Added a few new tests specifically for this + manually by triggering an access review notification.
Checklist
make all)make docs)