fix: use idiomatic "at most" in English max/lte messages - #1600
Merged
nodivbyzero merged 1 commit intoJul 29, 2026
Conversation
Fixes go-playground#1249. The English defaults for max-items, lte-items, and lte-string said "at maximum", which is unidiomatic. Align them with the existing "at least" min/gte wording and with doc.go, which already describes max string length as "at most". Leave max-string as "a maximum of", which is already correct English.
zemzale
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Fixes #1249.
English defaults for
max-items,lte-items, andlte-stringused "at maximum", which is unidiomatic. They now use "at most", matching the existing "at least" wording used by min/gte and the language already used indoc.gofor max string length ("at most").max-stringalready uses the correct phrase "a maximum of" and is left unchanged.The same sibling scope (max-items together with related upper-bound item messages) has landed before in translation work such as #1250 for Japanese.
Make sure that you've checked the boxes below before you submit PR:
Validation:
53a4402, updated expectations alone fail because the library still emits "at maximum"go test ./translations/enpasses on this branchCGO_ENABLED=0 go test -cover ./...passes (root package coverage 95.2%;-racenot run on this host for lack of CGO)@go-playground/validator-maintainers