Skip to content

feat: URN RFC 8141 - #1224

Merged
nodivbyzero merged 9 commits into
go-playground:masterfrom
leodido:feat/urn-8141
Jul 17, 2026
Merged

feat: URN RFC 8141#1224
nodivbyzero merged 9 commits into
go-playground:masterfrom
leodido:feat/urn-8141

Conversation

@leodido

@leodido leodido commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

Fixes Or Enhances

Fixes #1223

Follow-up from #429 by adding also the most recent URN validator as per RFC 8141 spec.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
leodido requested a review from a team as a code owner February 12, 2024 12:28
@coveralls

coveralls commented Feb 12, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 74.24% (+0.07%) from 74.172%
when pulling 3eaab96 on leodido:feat/urn-8141
into b328f72 on go-playground:master.

@leodido leodido changed the title fat: URN RFC 8141 feat: URN RFC 8141 Feb 12, 2024
Comment thread baked_in.go Outdated
leodido and others added 2 commits June 4, 2024 05:02
Co-authored-by: Dean Karn <Dean.Karn@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
leodido requested a review from deankarn July 11, 2024 09:43
@nodivbyzero

Copy link
Copy Markdown
Contributor

LGTM

@leodido Could you update the README.md with urn_rfc8141?

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido

leodido commented Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

@nodivbyzero done ✅

@leodido

leodido commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Ping

Comment thread baked_in.go
@nodivbyzero

Copy link
Copy Markdown
Contributor

@leodido
I reviewed this PR again. One minor issue and it's good to go.

@leodido
leodido requested a review from nodivbyzero July 17, 2026 07:34
@leodido

leodido commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@nodivbyzero done! PTAL

@nodivbyzero
nodivbyzero merged commit 53a4402 into go-playground:master Jul 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URN (RFC 8141) validator

4 participants