Fix knowledge base aside renaming all nested articles

[marifex]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.

Description

• Fixes [GLPI 12] All KB articles are visually renamed on Root Article renaming #25394

The knowledge base aside renders the article tree by nesting each child article inside its parent element. When an article was renamed (or its illustration changed), the title and illustration were updated with a descendant selector [data-glpi-kb-article-id="<id>"] [data-glpi-kb-article-title], which also matched every nested child. Renaming a parent (in particular the root, which contains everything) therefore visually renamed all its descendants until the page was refreshed. The database was never affected.

Both #updateAsideTitle() and #updateAsideIllustration() now update only the entry that belongs to the current article, using the same closest(...) === article guard already used by AsideController::findEmptyMenus() for the exact same nesting reason.

Note on tests

The update methods are private and rely on the full controller and DOM, so a unit test would need significant setup. I verified the fix against the real aside DOM structure: the descendant selector matched the parent and all nested children, while the corrected logic matches only the current article. Happy to add a test where you prefer.

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Powered by Qodo

[cconard96]

#25396 is open to resolve this issue as well. I missed linking it to the original issue.

[marifex]

Thanks, I missed #25396. Yours is more complete since it also covers the search results template, so let's go with that one. Closing this in favor of #25396.