Skip to content

kb fix modifying child aside data instead of just current article #25396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cconard96 wants to merge 2 commits into
base: 12.0/bugfixes
Choose a base branch
from
+5 −3
Open

kb fix modifying child aside data instead of just current article #25396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6cfa95
kb fix modifying child aside data instead of just current article
cconard96 Sep 3, 2026
0cb89d3
fix search result html structure
cconard96 Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/modules/Knowbase/ArticleController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ export class GlpiKnowbaseArticleController

const aside = document.querySelector('[data-main-page-aside="knowbaseitem"]');
const entries = aside.querySelectorAll(
`[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] [data-glpi-kb-article-title]`
`[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] > .article-line [data-glpi-kb-article-title]`
);
for (const entry of entries) {
entry.textContent = title;
Expand All @@ -598,7 +598,7 @@ export class GlpiKnowbaseArticleController

const aside = document.querySelector('[data-main-page-aside="knowbaseitem"]');
const containers = aside.querySelectorAll(
`[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] [data-glpi-kb-article-illustration]`
`[data-glpi-kb-article-id="${CSS.escape(String(this.#item_id))}"] > .article-line [data-glpi-kb-article-illustration]`
);

// The illustration picker preview already holds a freshly rendered node
Expand Down
4 changes: 3 additions & 1 deletion templates/pages/tools/kb/aside_search_results.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
{% endif %}
class="article"
>
<a class="d-block text-dark text-hover-link" href="{{ result.link }}">
<div class="article-line">
<a class="d-block text-dark text-hover-link" href="{{ result.link }}">
<span class="d-flex align-items-center">
<span
class="{{ result.illustration ? 'me-1' : '' }}"
Expand All @@ -71,6 +72,7 @@
</span>
{% endif %}
</a>
</div>
</li>
{% endfor %}

Expand Down
Loading