fix(hsv): name rgb2hsv converter correctly - #398
Open
xianjianlf2 wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Rename the internal converter function in
src/io/hsv/rgb2hsv.jsfromrgb2hsltorgb2hsv.Why
The file implements and exports RGB-to-HSV conversion, but the local function name still said
rgb2hsl. This is confusing when reading stack traces, debugging, or navigating the source, and it was reported in #363.Fixes #363
Validation
npm test -- test/io/rgb2hsv.test.js --runnpm run lintand fullnpm testsuccessfully: 50 test files, 2519 tests