fix: preserve alpha when interpolating in oklch - #394
Open
mahirhir wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 57b5ef5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared hue interpolator in
src/interpolator/_hsx.jsreverses the polar color so the hue ends up at index 0 for the hue-blending math. Foroklchit does that withArray.prototype.reverse():rgb2oklchappends the alpha channel when it is below 1, sooklch()returns[L, c, h, a]for a semi-transparent color.reverse()flips the whole array to[a, h, c, L], and the next line[hue0, sat0, lbv0] = xyz0then reads alpha as the hue, hue as the chroma and chroma as the lightness. So anyoklchinterpolation/mix where an input has alpha < 1 comes out wrong.The
hclbranch right above it does not have this problem:Color.prototype.hclwas switched toreverse3(in 27a2bb3, resolving #359), which only reverses the first three components and leaves alpha in place. Theoklchbranch was left on the oldreverse(). This change uses the samereverse3helper there.Mixing a half-transparent red with blue, the rgb part should match the opaque mix (only the alpha channel should differ):
Added a regression test in
test/mix.test.jsand a changeset. The full suite passes.