Skip to content

fix: log progress tracker refresh errors instead of silently swallowing #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quratulain-bilal wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −1
Open

fix: log progress tracker refresh errors instead of silently swallowing #3975

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
994f980
fix: log progress tracker refresh errors instead of silently swallowing
Quratulain-bilal Aug 3, 2026
e7b1067
test: add regression test for StepTracker refresh error logging
Quratulain-bilal Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/specify_cli/_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"""
from __future__ import annotations

import logging
import sys
from collections.abc import Callable

Expand All @@ -21,6 +22,8 @@
from rich.tree import Tree
from typer.core import TyperGroup

logger = logging.getLogger(__name__)

BANNER = """
███████╗██████╗ ███████╗ ██████╗██╗███████╗██╗ ██╗
██╔════╝██╔══██╗██╔════╝██╔════╝██║██╔════╝╚██╗ ██╔╝
Expand Down Expand Up @@ -85,7 +88,7 @@ def _maybe_refresh(self):
try:
self._refresh_cb()
except Exception:
pass
logger.debug("Progress tracker refresh failed", exc_info=True)
Comment thread
Quratulain-bilal marked this conversation as resolved.

def render(self):
tree = Tree(f"[cyan]{self.title}[/cyan]", guide_style="grey50")
Expand Down