Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Upgrades the MCP Go SDK to v1.7.0 and adapts compatibility fixtures and error assertions.
Changes:
- Bumps the SDK and transitive dependencies.
- Handles the new
server/discoverprobe in test fixtures. - Aligns backend error expectations with v1.7.0.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates dependency versions. |
| go.sum | Records updated checksums. |
| internal/mcp/connect_timeout_test.go | Updates the minimal handshake fixture. |
| internal/mcp/http_transport_test.go | Adapts the retry canary fixture. |
| internal/server/register_tools_from_backend_test.go | Updates the expected SDK error path. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/5 changed files
- Comments generated: 2
- Review effort level: Balanced
| require ( | ||
| github.com/BurntSushi/toml v1.6.0 | ||
| github.com/modelcontextprotocol/go-sdk v1.6.1 | ||
| github.com/modelcontextprotocol/go-sdk v1.7.0 |
| return | ||
| case http.MethodPost: | ||
| var req map[string]interface{} | ||
| require.NoError(t, json.NewDecoder(r.Body).Decode(&req)) |
This comment has been minimized.
This comment has been minimized.
|
@copilot address review feedback and fix failing ci check https://github.com/github/gh-aw-mcpg/actions/runs/31038901757/job/92437038393?pr=10734 |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Addressed in 2e6ce16 (fixed |
🔒 mcpg Read-Only Stress — gVisorSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Notes:
Overall: PASS Run: §31056783251
|
🔒 mcpg Read-Only Stress — default AWFSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS Notes:
References: §31056783215
|
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS
References: §31056783341
|
Updates the gateway’s core MCP dependency from
github.com/modelcontextprotocol/go-sdkv1.6.1 to v1.7.0 while preserving canary coverage for SDK-specific retry and tool-validation behavior.Dependency update
github.com/modelcontextprotocol/go-sdkto v1.7.0.golang.org/x/syncandgolang.org/x/timerequirements.SDK fixture compatibility
MethodNotFoundresponse for the SDK’s newserver/discoverprobe.202 Acceptedfor initialization notifications.