-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add history.clearContext and Tool.isTerminal across all SDKs
#2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
756630b
Add history.clearContext and Tool.isTerminal across all SDKs
examon 1ca9787
Preserve isTerminal in Java fluent copies, add Node isTerminal wire t…
examon 012f981
Regenerate clearContext bindings for the tightened runtime contract
examon 5000d02
Close the two remaining reviewer findings on isTerminal
examon 3ba3ff2
Fix @since on the new Java isTerminal setter
examon dd52cc3
Expose isTerminal through Java tool annotations
SteveSandersonMS c19fdd8
Test .NET terminal tools on session requests
SteveSandersonMS 2df3d72
Cover terminal tool runtime behavior end to end
SteveSandersonMS b41fb67
Document context clearing and terminal tools
SteveSandersonMS 862fa3f
Normalize clear context snapshot formatting
SteveSandersonMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
java/src/test/java/com/github/copilot/rpc/ToolDefinitionIsTerminalTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
| package com.github.copilot.rpc; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import java.util.Map; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** Wire-level coverage for {@link ToolDefinition#isTerminal()}. */ | ||
| class ToolDefinitionIsTerminalTest { | ||
|
|
||
| private static final ObjectMapper MAPPER = new ObjectMapper(); | ||
|
|
||
| @Test | ||
| void isTerminalSerializesAsCamelCaseWhenSet() throws Exception { | ||
| ToolDefinition definition = new ToolDefinition("clear_context", "Clear the conversation", | ||
| Map.of("type", "object"), null, null, null, null, null, true); | ||
|
|
||
| JsonNode node = MAPPER.valueToTree(definition); | ||
|
|
||
| assertTrue(node.has("isTerminal"), "isTerminal should be serialized"); | ||
| assertTrue(node.get("isTerminal").asBoolean(), "isTerminal should be true"); | ||
| } | ||
|
|
||
| @Test | ||
| void isTerminalIsOmittedWhenNull() throws Exception { | ||
| ToolDefinition definition = new ToolDefinition("plain", "A plain tool", Map.of("type", "object"), null, null, | ||
| null, null, null, null); | ||
|
|
||
| JsonNode node = MAPPER.valueToTree(definition); | ||
|
|
||
| assertFalse(node.has("isTerminal"), "isTerminal should be omitted when null"); | ||
| } | ||
|
|
||
| @Test | ||
| void sevenArgumentConstructorStillCompilesAndLeavesTerminalityUnset() throws Exception { | ||
| // Guards source compatibility for call sites written before isTerminal | ||
| // was added as a record component. | ||
| ToolDefinition definition = new ToolDefinition("legacy", "Legacy call site", Map.of("type", "object"), null, | ||
| null, null, null); | ||
|
|
||
| assertEquals(null, definition.isTerminal()); | ||
| assertFalse(MAPPER.valueToTree(definition).has("isTerminal")); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.