Unified: Add static name binding pass

shared/namebinding/codeql/namebinding/LocalNameBinding.qll

@@ -136,6 +136,12 @@ signature module LocalNameBindingInputSig<LocationSig Location> {
    * full control of scope resolution for specific types of references.
    */
   default predicate lookupStartsAt(AstNode n, AstNode scope) { none() }
+
+  /**
+   * Holds if the set of names available in `scope` is not known ahead of time,
+   * and thus any lookup chain that goes through `scope` may need to be reconciled at a later stage.
+   */
+  default predicate uncertainScope(AstNode scope) { none() }
 }
 
 /**
@@ -154,6 +160,8 @@ module LocalNameBinding<LocationSig Location, LocalNameBindingInputSig<Location>
       implicitDeclInScope(_, this)
       or
       isTopScope(this)
+      or
+      uncertainScope(this)
     }
   }
 
@@ -353,6 +361,27 @@ module LocalNameBinding<LocationSig Location, LocalNameBindingInputSig<Location>
     )
   }
 
+  /**
+   * Holds if `name`, when resolved from `lookup`, may resolve to one of the uncertain members of `scope`.
+   */
+  pragma[nomagic]
+  private predicate lookupInUncertainScope(string name, Scope lookup, Scope scope) {
+    lookupInScope(name, lookup, scope) and
+    uncertainScope(scope) and
+    not declInScope(_, name, scope) and
+    not implicitDeclInScope(name, scope)
+  }
+
+  /**
+   * Gets an uncertain scope that the given `accessCand` pair may resolve to.
+   */
+  AstNode getAnUncertainScope(AstNode access, string name) {
+    exists(Scope lookup |
+      accessCandInLookupScope(access, name, lookup) and
+      lookupInUncertainScope(name, lookup, result)
+    )
+  }
+
   cached
   private newtype TLocal =
     TExplicitLocal(AstNode definingNode, string name, AstNode scope) {

unified/extractor/ast_types.yml

@@ -413,6 +413,7 @@ named:
   name_pattern:
     modifier*: modifier
     identifier: identifier
+    sub_pattern?: pattern
 
   # A pattern matching anything, binding no variables, usually using the syntax "_"
   ignore_pattern:

unified/extractor/tests/corpus/swift/control-flow/nested-enum-case-pattern.output

@@ -0,0 +1,160 @@
+switch event {
+case let .received(.some(value), timestamp):
+  print(value, timestamp)
+default:
+  break
+}
+
+---
+
+sourceFile
+  endOfFileToken: endOfFile
+  statements:
+    codeBlockItem
+      item:
+        expressionStmt
+          expression:
+            switchExpr
+              leftBrace: {
+              rightBrace: }
+              cases:
+                switchCase
+                  label:
+                    switchCaseLabel
+                      colon: :
+                      caseKeyword: case
+                      caseItems:
+                        switchCaseItem
+                          pattern:
+                            valueBindingPattern
+                              pattern:
+                                expressionPattern
+                                  expression:
+                                    functionCallExpr
+                                      leftParen: (
+                                      rightParen: )
+                                      arguments:
+                                        labeledExpr
+                                          expression:
+                                            functionCallExpr
+                                              leftParen: (
+                                              rightParen: )
+                                              arguments:
+                                                labeledExpr
+                                                  expression:
+                                                    patternExpr
+                                                      pattern:
+                                                        identifierPattern
+                                                          identifier: identifier "value"
+                                              additionalTrailingClosures:
+                                              calledExpression:
+                                                memberAccessExpr
+                                                  period: .
+                                                  declName:
+                                                    declReferenceExpr
+                                                      baseName: identifier "some"
+                                          trailingComma: ,
+                                        labeledExpr
+                                          expression:
+                                            patternExpr
+                                              pattern:
+                                                identifierPattern
+                                                  identifier: identifier "timestamp"
+                                      additionalTrailingClosures:
+                                      calledExpression:
+                                        memberAccessExpr
+                                          period: .
+                                          declName:
+                                            declReferenceExpr
+                                              baseName: identifier "received"
+                              bindingSpecifier: let
+                  statements:
+                    codeBlockItem
+                      item:
+                        functionCallExpr
+                          leftParen: (
+                          rightParen: )
+                          arguments:
+                            labeledExpr
+                              expression:
+                                declReferenceExpr
+                                  baseName: identifier "value"
+                              trailingComma: ,
+                            labeledExpr
+                              expression:
+                                declReferenceExpr
+                                  baseName: identifier "timestamp"
+                          additionalTrailingClosures:
+                          calledExpression:
+                            declReferenceExpr
+                              baseName: identifier "print"
+                switchCase
+                  label:
+                    switchDefaultLabel
+                      colon: :
+                      defaultKeyword: default
+                  statements:
+                    codeBlockItem
+                      item:
+                        breakStmt
+                          breakKeyword: break
+              subject:
+                declReferenceExpr
+                  baseName: identifier "event"
+              switchKeyword: switch
+
+---
+
+top_level
+  body:
+    block
+      stmt:
+        switch_expr
+          value:
+            name_expr
+              identifier: identifier "event"
+          case:
+            switch_case
+              pattern:
+                constructor_pattern
+                  constructor:
+                    member_access_expr
+                      base: inferred_type_expr "."
+                      member: identifier "received"
+                  element:
+                    pattern_element
+                      pattern:
+                        constructor_pattern
+                          constructor:
+                            member_access_expr
+                              base: inferred_type_expr "."
+                              member: identifier "some"
+                          element:
+                            pattern_element
+                              pattern:
+                                name_pattern
+                                  identifier: identifier "value"
+                    pattern_element
+                      pattern:
+                        name_pattern
+                          identifier: identifier "timestamp"
+              body:
+                block
+                  stmt:
+                    call_expr
+                      callee:
+                        name_expr
+                          identifier: identifier "print"
+                      argument:
+                        argument
+                          value:
+                            name_expr
+                              identifier: identifier "value"
+                        argument
+                          value:
+                            name_expr
+                              identifier: identifier "timestamp"
+            switch_case
+              body:
+                block
+                  stmt: break_expr "break"

unified/extractor/tests/corpus/swift/control-flow/nested-enum-case-pattern.swift

@@ -0,0 +1,6 @@
+switch event {
+case let .received(.some(value), timestamp):
+  print(value, timestamp)
+default:
+  break
+}

unified/extractor/tests/corpus/swift/expressions/array-type-constructor.output

@@ -0,0 +1,74 @@
+let values = [Result<Void>]()
+
+---
+
+sourceFile
+  endOfFileToken: endOfFile
+  statements:
+    codeBlockItem
+      item:
+        variableDecl
+          attributes:
+          modifiers:
+          bindingSpecifier: let
+          bindings:
+            patternBinding
+              initializer:
+                initializerClause
+                  equal: =
+                  value:
+                    functionCallExpr
+                      leftParen: (
+                      rightParen: )
+                      arguments:
+                      additionalTrailingClosures:
+                      calledExpression:
+                        arrayExpr
+                          elements:
+                            arrayElement
+                              expression:
+                                genericSpecializationExpr
+                                  expression:
+                                    declReferenceExpr
+                                      baseName: identifier "Result"
+                                  genericArgumentClause:
+                                    genericArgumentClause
+                                      arguments:
+                                        genericArgument
+                                          argument:
+                                            identifierType
+                                              name: identifier "Void"
+                                      leftAngle: <
+                                      rightAngle: >
+                          leftSquare: [
+                          rightSquare: ]
+              pattern:
+                identifierPattern
+                  identifier: identifier "values"
+
+---
+
+top_level
+  body:
+    block
+      stmt:
+        variable_declaration
+          modifier: modifier "let"
+          pattern:
+            name_pattern
+              identifier: identifier "values"
+          value:
+            call_expr
+              callee:
+                generic_type_expr
+                  base:
+                    named_type_expr
+                      name: identifier "Array"
+                  type_argument:
+                    generic_type_expr
+                      base:
+                        named_type_expr
+                          name: identifier "Result"
+                      type_argument:
+                        named_type_expr
+                          name: identifier "Void"

unified/extractor/tests/corpus/swift/expressions/array-type-constructor.swift

@@ -0,0 +1 @@
+let values = [Result<Void>]()

unified/extractor/tests/corpus/swift/expressions/array-type-metatype.output

@@ -0,0 +1,75 @@
+let type = [Result<Void>].self
+
+---
+
+sourceFile
+  endOfFileToken: endOfFile
+  statements:
+    codeBlockItem
+      item:
+        variableDecl
+          attributes:
+          modifiers:
+          bindingSpecifier: let
+          bindings:
+            patternBinding
+              initializer:
+                initializerClause
+                  equal: =
+                  value:
+                    memberAccessExpr
+                      period: .
+                      declName:
+                        declReferenceExpr
+                          baseName: self
+                      base:
+                        arrayExpr
+                          elements:
+                            arrayElement
+                              expression:
+                                genericSpecializationExpr
+                                  expression:
+                                    declReferenceExpr
+                                      baseName: identifier "Result"
+                                  genericArgumentClause:
+                                    genericArgumentClause
+                                      arguments:
+                                        genericArgument
+                                          argument:
+                                            identifierType
+                                              name: identifier "Void"
+                                      leftAngle: <
+                                      rightAngle: >
+                          leftSquare: [
+                          rightSquare: ]
+              pattern:
+                identifierPattern
+                  identifier: identifier "type"
+
+---
+
+top_level
+  body:
+    block
+      stmt:
+        variable_declaration
+          modifier: modifier "let"
+          pattern:
+            name_pattern
+              identifier: identifier "type"
+          value:
+            member_access_expr
+              base:
+                generic_type_expr
+                  base:
+                    named_type_expr
+                      name: identifier "Array"
+                  type_argument:
+                    generic_type_expr
+                      base:
+                        named_type_expr
+                          name: identifier "Result"
+                      type_argument:
+                        named_type_expr
+                          name: identifier "Void"
+              member: identifier "self"

unified/extractor/tests/corpus/swift/expressions/array-type-metatype.swift

@@ -0,0 +1 @@
+let type = [Result<Void>].self

unified/extractor/tests/corpus/swift/functions/leading-dot-expression-call.output

@@ -51,7 +51,7 @@ top_level
             call_expr
               callee:
                 member_access_expr
-                  base: inferred_type_expr ".some"
+                  base: inferred_type_expr "."
                   member: identifier "some"
               argument:
                 argument

unified/extractor/tests/corpus/swift/functions/leading-dot-expression-value.output

@@ -39,5 +39,5 @@ top_level
               identifier: identifier "x"
           value:
             member_access_expr
-              base: inferred_type_expr ".foo"
+              base: inferred_type_expr "."
               member: identifier "foo"