fix the unified col_reduction_2d on many cols - #2074
Open
yhmtsai wants to merge 1 commit into
Open
Conversation
yhmtsai
force-pushed
the
fix_reduction_col
branch
from
August 24, 2026 08:06
6bff862 to
6407d56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA only support up to 65535 for y-axis of grid.
when col_reduction_2d on more than 65535 * 32 cols, it will lead invalid configuration for kernels.
Note. this currently contain the test to show the failure only. After some ci showing the error, I will push the fix
TODO: