allow pgm to generate weight without symmetrization - #2071
Open
yhmtsai wants to merge 2 commits into
Open
Conversation
ginkgo-bot
added
reg:testing
yhmtsai
force-pushed
the
create_hermitian_weight_pgm
branch
from
August 21, 2026 14:29
d60284c to
1281634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously always generate the weight matrix = (abs(mtx) + abs(mtx'))/2, but it is unnecessary for hermitian matrix. We can simply have weight matrix = abs(mtx), which can reduce the memory footprint during generation.
Another question: I am thinking whether abs(mtx + mtx')/2 makes more sense?