1888/derive dist vector - #2069
Open
MarcelKoch wants to merge 2 commits into
Open
Conversation
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 18, 2026 14:37
2efa831 to
f284722
Compare
MarcelKoch
force-pushed
the
1888/derive-dist-vector
branch
2 times, most recently
from
August 18, 2026 14:57
ed710a9 to
1dc8c10
Compare
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 18, 2026 14:57
f284722 to
152f952
Compare
MarcelKoch
added
1:ST:ready-for-review
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 19, 2026 12:38
152f952 to
449b684
Compare
MarcelKoch
force-pushed
the
1888/derive-dist-vector
branch
from
August 19, 2026 12:38
1dc8c10 to
d0862a3
Compare
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 19, 2026 12:56
449b684 to
bfbe9df
Compare
MarcelKoch
force-pushed
the
1888/derive-dist-vector
branch
from
August 19, 2026 12:56
d0862a3 to
d22dff9
Compare
yhmtsai
approved these changes
Aug 19, 2026
Comment on lines
+806
to
+807
| const typename Vector<ValueType>::value_type* | ||
| Vector<ValueType>::get_const_local_values() const |
Member
There was a problem hiding this comment.
Suggested change
| const typename Vector<ValueType>::value_type* | |
| Vector<ValueType>::get_const_local_values() const | |
| auto Vector<ValueType>::get_const_local_values() const -> const value_type* |
This can avoid the long access to member type
Member
Author
There was a problem hiding this comment.
Yes, I had this before, but I don't think we should do it, since it's inconsistent with the other function signatures.
Comment on lines
+703
to
+705
| } else if constexpr (is_complex<ValueType>() && | ||
| std::is_same_v<to_complex<OtherValueType>, | ||
| ValueType>) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR derives the distributed
Vectorfrom theAbstractMulitVectorinterface.