1888/derive multivector - #2068
Open
MarcelKoch wants to merge 10 commits into
Open
Conversation
ginkgo-bot
added
reg:testing
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 18, 2026 14:37
2efa831 to
f284722
Compare
MarcelKoch
force-pushed
the
1888/multivector
branch
from
August 18, 2026 14:57
046c2c4 to
2918d52
Compare
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 18, 2026 14:57
f284722 to
152f952
Compare
MarcelKoch
added
1:ST:ready-for-review
MarcelKoch
force-pushed
the
1888/multivector
branch
from
August 19, 2026 12:38
2918d52 to
b98f21d
Compare
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 19, 2026 12:38
152f952 to
449b684
Compare
This reverts commit 1853c82.
MarcelKoch
force-pushed
the
1888/derive-multivector
branch
from
August 19, 2026 12:56
449b684 to
bfbe9df
Compare
MarcelKoch
force-pushed
the
1888/multivector
branch
from
August 19, 2026 12:56
b98f21d to
da07af9
Compare
yhmtsai
reviewed
Aug 19, 2026
Comment on lines
-105
to
+103
| using value_type = ValueType; | ||
| using value_type = typename EnableMultiVector<MultiVector>::value_type; |
Member
Author
There was a problem hiding this comment.
For consistency. EnableMultiVector already defines value_type, so we should (need) to use the same here.
Comment on lines
+175
to
+177
| std::unique_ptr<MultiVector> transpose() const; | ||
|
|
||
| std::unique_ptr<LinOp> conj_transpose() const override; | ||
| std::unique_ptr<MultiVector> conj_transpose() const; |
Member
There was a problem hiding this comment.
should multivector have transpose? or rather calling from dense matrix?
Member
Author
There was a problem hiding this comment.
I'm open to removing it. I have no strong opinion for it to stay.
Comment on lines
+1200
to
+1207
| } else if constexpr (is_complex<ValueType>() && | ||
| std::is_same_v<to_complex<OtherValueType>, | ||
| ValueType>) { | ||
| // The value type of this is complex and the other value type is the | ||
| // corresponding real value type (std::complex<double> vs double). | ||
| // This conversion is allowed, since the real view of this can be used | ||
| return temporary_conversion<MultiVector<OtherValueType>>::create( | ||
| this->create_real_view()); |
Member
There was a problem hiding this comment.
I think if only check is_complex<ValueType>, it will allow mixedComplex version again?
Member
Author
There was a problem hiding this comment.
I will check again if it works. I remember that it didn't the last time I tried. (Because the target for the copy-back step wouldn't be alive anymore.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR derives the
Dense(hereMultiVector) class from theAbstractMultiVectorinterface.